compilers: fix clang-cl cross without setting many args on cc - #15367
Merged
Merged
Conversation
mochaaP
force-pushed
the
mochaa/clang-cl-cross
branch
from
December 9, 2025 20:59
da492cb to
bd3e854
Compare
normal compilers does not rely on the position of this argument, but MSVC-like compilers treat `/link` and any argument after that as linker arguments. MSVC-like compiler's linker_to_compiler_args inject `/link` before largs, resulting it being forwarded to link.exe not the compiler driver. fixes cross compiling with cc = clang-cl and c_ld = lld-link.
this function does not pass enough args from the compiler object to find windows sdk without relying on environment variables. including a file from the same directory removes the dependency on stdlib.
mochaaP
force-pushed
the
mochaa/clang-cl-cross
branch
from
May 27, 2026 18:52
bd3e854 to
c76bc33
Compare
Contributor
Author
|
rebased |
Member
|
I'm not going to claim I'm an expert at this, but the code looks reasonable. |
dcbaker
approved these changes
May 27, 2026
dcbaker
left a comment
dcbaker
left a comment
Member
There was a problem hiding this comment.
I'm giving an approve, if no one else chimes in with concerns I'll plan to merge this next week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the expanded commit messages for explanations.
Before:
After:
The
detect_vs_dep_prefixchange needs more testing. I tested this on:Closes #15851